Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(live-11604): clean up swap legacy code and flags #8555

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(live-11604): clean up swap legacy code and flags #8555

wants to merge 1 commit into from
+67 −4,823

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented Dec 2, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • removed unsued swap legacy code
  • removed old swap feature flags
  • always load swap live app
  • ptxSwapDemoThree flag is used only for pointing the manifest id of live app
swap.live.app.always.load.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested review from a team as code owners December 2, 2024 07:08
@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 9:47am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 9:47am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 9:47am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 9:47am

@liviuciulinaru liviuciulinaru marked this pull request as draft December 2, 2024 07:09
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Dec 2, 2024
@liviuciulinaru liviuciulinaru force-pushed the feat/live-11604/clean-up-demozero branch from f158b31 to 1705054 Compare December 3, 2024 08:01
@liviuciulinaru liviuciulinaru force-pushed the feat/live-11604/clean-up-demozero branch from 6b5c7b5 to 407c955 Compare December 3, 2024 15:57
@liviuciulinaru liviuciulinaru marked this pull request as ready for review December 3, 2024 16:27
@liviuciulinaru
feat: clean up old swap feature flags
2b3bcfd 
feat: rm legacy code

fix: borken tests

fix: rm unused hooks

fix: tsc

fix: unsuned import

fix: rm unused files

fix: rm legacy swap lld code

chore: pr comments
@liviuciulinaru liviuciulinaru force-pushed the feat/live-11604/clean-up-demozero branch from ad112c8 to 2b3bcfd Compare December 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallen-ledger kallen-ledger Awaiting requested review from kallen-ledger

@CremaFR CremaFR Awaiting requested review from CremaFR

At least 1 approving review is required to merge this pull request.

Assignees

@liviuciulinaru liviuciulinaru

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liviuciulinaru @CremaFR @kallen-ledger